Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed DictType from TVM #69

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Removed DictType from TVM #69

wants to merge 2 commits into from

Conversation

vkovinicTT
Copy link
Member

@vkovinicTT vkovinicTT commented Mar 5, 2025

Removed DictType from TVM as it was initially added by us.

This is corresponding TVM PR.

Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, just move from Draft to Ready state :))

@@ -1,6 +1,3 @@
// SPDX-FileCopyrightText: © 2019-2023 The Apache Software Foundation © 2024 Tenstorrent AI ULC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this resetting this file to the original? If so, can remove SPDX headers

@@ -2848,7 +2835,8 @@ def index(self, inputs, input_types):

def meshgrid(self, inputs, input_types):
data = inputs[0]
return _op.meshgrid(data, indexing="ij")
indexing = inputs[1] if len(inputs) > 1 else "ij"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants